build: Update (internal) node version to 16.x#6236
Conversation
| - name: Run Canary Tests | ||
| env: | ||
| E2E_TEST_PUBLISH_SCRIPT_NODE_VERSION: ${{ env.DEFAULT_NODE_VERSION }} | ||
| E2E_TEST_PUBLISH_SCRIPT_NODE_VERSION: ${{ steps.versions.outputs.node }} |
There was a problem hiding this comment.
@lforst Do we actually need to set this, when it is the default installed node version? 🤔 Just wondering, because in the canary tests it was actually also setting it to env.DEFAULT_NODE_VERSION, which isn't actually set there 😅 (same applies then to the non-canary tests I guess)
There was a problem hiding this comment.
I can't speak to the end-to-end tests, but as for the others, GH recommends always being explicit, so I think it's not a bad thing to do.
There was a problem hiding this comment.
We use this env variable to set what node version we use to fake publish our packages in the E2E tests. The version should always align with the version we actually publish our packages with. If in the future we want to do our E2E tests with multiple node versions this will be necessary. Here is how this came to be: #5806 (comment) Looking back at it now, I probably wouldn't do it again this way. Maybe we can simplify.
As for the canary tests: Looks like I forgot to copy the env var over. (Which wasn't too bad since right now we only tested with the default node version anyways but good that you caught it.)
There was a problem hiding this comment.
makes sense. So we can leave this in (this parses the node version defined for volta, so it is still consistent, but we can change it later if needed)!
size-limit report 📦
|
lobsterkatie
left a comment
lobsterkatie
left a comment
There was a problem hiding this comment.
Nice - didn't know volta had a GH action!
5 participants
This updates the node version we use internally from 14.x to 16.x.
Note that node support policy remains the same (and is tested), so nothing should change externally.
While at it, I also updated CI to actually use volta to setup node. This way, we can use a centralized place to specify the node version for dev & ci.